Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the possibility to select all the cultures at once in the save and save&publish dialogs #15776

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

fg-gsc
Copy link
Contributor

@fg-gsc fg-gsc commented Feb 27, 2024

Description

Implements this #15297

Added a new checkbox on the top of the cultures' list inside the save/save&publish dialogs to allow editors to select all the items at once.

Testing

  1. Add at least 2 languages in your Umbraco backoffice
  2. Create a document type which vary by culture
  3. Create a new node, edit at least 2 cultures and click save or save&publish
  4. Click the checkbox "Select all variants" and all the cultures in the list will be selected

If you edit just 1 culture the checkbox "Select all variants" should be hidden

--

While editing multiple cultures:
image

While editing one single culture:
image

Copy link

github-actions bot commented Feb 27, 2024

Hi there @fg-gsc, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@emmagarland
Copy link
Contributor

Hi @fg-gsc!

Thanks for your PR to implement #15297, select all cultures in publish & save.

One of the Core Collaborators team will review this as soon as possible - it is also something we'll want to port into Bellissima!

Also, it looks like this is your first PR to this repository! Nice work! #H5YR 🎉

Best wishes

Emma

@emmagarland emmagarland added community/pr project/bellissima AKA "the new backoffice" labels Feb 28, 2024
@emmagarland emmagarland self-assigned this Feb 28, 2024
@emmagarland emmagarland merged commit 7a7b846 into umbraco:contrib Feb 28, 2024
4 of 6 checks passed
@emmagarland
Copy link
Contributor

Hi @fg-gsc thanks so much for your pull request. It has now been successfully merged and tagged for porting to Bellissima too! 🙌

It looks like this is your first time contributing to Umbraco CMS, great work! 🎉

If have an account on our.umbraco.com please feel free to drop a comment below with your account name.

@nul800sebastiaan or one of the team will add you a lovely new C-Trib badge to your profile! 🏅

Cheers!

@fg-gsc
Copy link
Contributor Author

fg-gsc commented Feb 29, 2024

Hi @emmagarland thank you!
I have indeed an account on our.umbraco.com with username "tbloglog" and full name Francesco Guidi 😃

@nul800sebastiaan
Copy link
Member

Thanks again @fg-gsc and congrats on your new shiny contrib badge! 🥇 https://our.umbraco.com/members/tbloglog/

@simonech
Copy link
Contributor

simonech commented Apr 5, 2024

Hi, I just checked the release notes of 13.3.0 RC and I don't see it mentioned:
https://our.umbraco.com/download/releases/1330
is it a mistake in the release notes or was the feature not added yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants