Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes more old backoffice files + Smidge! #15788

Merged
merged 2 commits into from Feb 28, 2024

Conversation

bergmania
Copy link
Member

Description

This removes a lot of classes only used by the old backoffice.

Furthermore this allows us to remove Smidge (Breaking), but users can add a dependency them selves, if they really use it on the website. We dont expect many to do that.

Breaking changes

  • Smidge package has been removed
  • IRuntimeMinifier is removed

Tests

  • Ensure install or upgrades works
  • Smoke test the new backoffice

Copy link
Contributor

@kjac kjac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🤩 and tests out great too 💪

@bergmania bergmania merged commit 3fea1b4 into v14/dev Feb 28, 2024
12 of 15 checks passed
@bergmania bergmania deleted the v14/feature/kill-old-backoffice-classes branch February 28, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants