A bunch of minor performance optimizations #16335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…more than 2100 parameters
…v13/hotfix/performance-optimizations-based-on-eu-data
…timizations-based-on-eu-data
…nce-optimizations-based-on-eu-data-kja-suggestions' into v13/hotfix/performance-optimizations-based-on-eu-data
…ations-based-on-eu-data
…ations-based-on-eu-data
…v13/hotfix/performance-optimizations-based-on-eu-data # Conflicts: # version.json
…otfix/performance-optimizations-based-on-eu-data
bergmania
added
category/performance
Migaroez
reviewed
Jun 3, 2024
| IUserRepository userRepository, | ||
| IUserGroupRepository userGroupRepository, | ||
| IOptions<GlobalSettings> globalSettings, | ||
| IRequestCache requestCache) |
There was a problem hiding this comment.
I don't like that we have a requestCache in a entity service.
Think it would be better to do something like the BlockEditorElementTypeCache introduced in this PR to separate the caching behavior from the actual retrieval from persistance.
Migaroez
approved these changes
Jun 3, 2024
Migaroez
deleted the
v13/hotfix/performance-optimizations-based-on-eu-data
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains a series of smaller performance improvements, found when working the a massive dataset.