Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow http for openiddict #16614

Merged

Conversation

bergmania
Copy link
Member

@bergmania bergmania commented Jun 18, 2024

Description

Added post configuration of OpenIddictServerOptions that removes the ValidateTransportSecurityRequirement iff GlobalSettings.UseHttps is false.

Fixing: #16605

Test

Please note that openiddict only allow connections from the host that first attempted to access backoffice. It can make it easier to set launchBrowser to false in launchSettings.json

…ValidateTransportSecurityRequirement iff globalsettings.usehttps is false.
Copy link
Member

@elit0451 elit0451 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and tests out good 💪

@elit0451 elit0451 merged commit 75c42f4 into v14/dev Jun 19, 2024
15 checks passed
@elit0451 elit0451 deleted the v14/bugfix/allow-http-requests-when-usehttps-is-false branch June 19, 2024 13:21
@kevinchalet
Copy link

👋🏻

FYI: removing the ValidateTransportSecurityRequirement event handler is not necessary to disable the TLS/HTTPS requirement as there's a dedicated OpenIddictServerAspNetCoreOptions.DisableTransportSecurityRequirement option that allows disabling this security check (when set to true, the built-in ValidateTransportSecurityRequirement handler is not called) 😃

Cheers.

@bergmania
Copy link
Member Author

bergmania commented Jun 19, 2024

I simplified the PR here #16629. Thanks for the input @kevinchalet 💪

@kevinchalet
Copy link

You're welcome @bergmania 😄

On a related note, OpenIddict 5.7.0 just shipped: https://github.com/openiddict/openiddict-core/releases/tag/5.7.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants