TinyMCE - oneTimeClick, changes the target of the floatpanel query #1754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As outlined in ticket U4-9524, if the "Formats" dropdown on the TinyMCE editor used, then the RTE is destroyed, the "floatpanel" element still exists in the DOM.
If the RTE is re-created, and the "Formats" dropdown selected again, this will force the editor control to close (and not apply the formatting).
This fix is to workaround the orphaned "floatpanel" elements in the DOM, by changing the target of the jQuery selector from `el` to `event.target`.
e.g. `el` would equal the tag-name ("span"), _bit too generic_,, whereas `event.target` would be the "Formats" menu item element.
ref: http://issues.umbraco.org/issue/U4-9524
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As outlined in ticket U4-9524, if the "Formats" dropdown on the TinyMCE editor used, then the RTE is destroyed, the "floatpanel" element still exists in the DOM.
If the RTE is re-created, and the "Formats" dropdown selected again, this will force the editor control to close (and not apply the formatting).
This fix is to workaround the orphaned "floatpanel" elements in the DOM, by changing the target of the jQuery selector from
eltoevent.target.e.g.
elwould equal the tag-name ("span"), bit too generic,, whereasevent.targetwould be the "Formats" menu item element.