Added fallback URLs for the "umbNodePreview" directive #2369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue created here: http://issues.umbraco.org/issue/U4-10805
Historically Umbraco 7 has used
<a>elements for handling links - eg. to content, document types or other stuff within the backoffice. Over time, for at least some of these links, thehrefattribute has been replaced withng-click. This basically kills the option to work with multiple browser tabs, as you no longer can open links in a new tab - which is really a shame.With this pull request, I've introduced an optional fallback URL for the three methods - open, edit and remove. With the fallback URL in place, a user can now right click on a link (or press the middle mouse button if one's mouse supports this), and choose to open the URL in a new tab. IMO this improves the user experience greatly.
This pull request specifically targets the
umbNodePreviewandumbContentNodeInfodirectives (see the screenshot above).The list view has been affected by the same problem for a while now (you can't right click on an item and open it in a new tab):
http://issues.umbraco.org/issue/U4-8655
Other parts of the backoffice may be affected as well.