Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UDUF - UA-10819 - LastPasswordChangeDate not updating #2461

Closed
wants to merge 1 commit into from
Closed

UDUF - UA-10819 - LastPasswordChangeDate not updating #2461

wants to merge 1 commit into from

Conversation

nullreferrer
Copy link

@nullreferrer nullreferrer commented Feb 22, 2018

UA-10819 - LastPasswordChangeDate not updating when password changed through the backoffice. http://issues.umbraco.org/issue/U4-10819

…hen password changed through the backoffice
@nullreferrer nullreferrer changed the title Fixed umbraco ticket UA-10819 - LastPasswordChangeDate not updating UA-10819 - LastPasswordChangeDate not updating Feb 22, 2018
@nul800sebastiaan
Copy link
Member

Thanks @thejocus this is a nice update but I'm afraid it might not be the right place to do this, we shouldn't need to save the user again, surely it must be saving already somewhere else and that's where we forget to update the LastPasswordChangeDate? Any hints @Shazwazza ?

@nul800sebastiaan
Copy link
Member

All of this code seems to end up in umbraco.providers.UsersMembershipProvider which is obsolete, but since it's being used still it might be the best place to update some of those methods?

Better could be in the Umbraco.Core.Services.UserService.Save(IEnumerable<IUser> entities, bool raiseEvents = true) method. We could maybe check if the password property is dirty and set the date there?

@Shazwazza
Copy link
Contributor

We need to review this and another one that is fixing this: #2463

@Shazwazza Shazwazza changed the title UA-10819 - LastPasswordChangeDate not updating UDUF - UA-10819 - LastPasswordChangeDate not updating Feb 26, 2018
@nul800sebastiaan nul800sebastiaan changed the base branch from dev-v7.8 to dev-v7 February 27, 2018 10:47
@nul800sebastiaan
Copy link
Member

Thanks @thejocus - this was resolved with #2463 in a more comprehensive way so I'll close this one. Hope to see more contributions from you in the future though! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants