-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V8 LogViewer #2926
Merged
Merged
V8 LogViewer #2926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ill have to disable this component & register their own implementation) Get some more of the basic WebAPI stubs fleshed out to get some data to start using in the UI layer
…gviewer # Conflicts: # src/Umbraco.Web.UI.Client/bower.json
…ion filter queries in POSTMAN
…y as we have a LogController already for audit logs
…ing up loggers to query the same LogEvents loaded into memory * StartsWith(SourceContext, 'Umbraco.Core') * StartsWith(SourceContext, 'Umbraco.Core') and @MessageTemplate='[Timing {TimingId}] {EndMessage} ({TimingDuration}ms)' * @MessageTemplate='[Timing {TimingId}] {EndMessage} ({TimingDuration}ms)' and TimingDuration > 1000
…makes it more explicit
* List number of total errors * Pie Chart of log level counts * Message counts * Log items with paging & searching
* Toggle timestamp order by ascending or descending
…rialised EX back to proper exceptions so we call ToString on it instead
* Output ex nicer * Add log level colours to badges * Output date in friendlier format
…arty devs. Say from Azure Table Storage for example
…checkboxes to filter by log levels
…name for timestamp
@Shazwazza & @zpqrtbnk I would love some early tech/code review on this please before I code myself into a corner & to ensure it is performant as it can be, Thx 😄 |
…plates and their counts In the UI we display the total count of unique but use LimitTo AngularJS filter to continue to display 10 items Returning all items so that we have a way to show the next 10 items or similar
…an a massive RED background Starts work on getting the dropdown for some example queries setup
# Conflicts: # src/Umbraco.Web.UI.Client/src/common/services/navigation.service.js
# Conflicts: # src/Umbraco.Core/Migrations/Install/DatabaseSchemaCreator.cs
# Conflicts: # src/Umbraco.Web.UI.Client/package-lock.json
# Conflicts: # src/Umbraco.Core/Migrations/Install/DatabaseSchemaCreator.cs # src/Umbraco.Web.UI.Client/gulpfile.js # src/Umbraco.Web.UI/config/trees.Release.config # src/Umbraco.Web.UI/config/trees.config
…t parameters with DI hence needed to use factory & new up an instance
# Conflicts: # src/Umbraco.Core/Migrations/Install/DatabaseSchemaCreator.cs
Temp8 logviewer review fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress to consider adding in a built in LogViewer to Umbraco V8 Core
Why do this?
Currently, for all Cloud sites, we use a community package called Trace Log Viewer which is a popular community package.
It makes sense to have this part of the core Umbraco product to have a way to view, filter and query the logs that we are reporting from Umbraco, as opposed to a community package. This way everyone benefits from it, not just sites running on Umbraco Cloud.
With the upcoming Umbraco Headless project, there is no direct file access and this will be the only way for customers to see & view the logs that the Umbraco headless project is reporting.
What does it do?
This PR adds in a new tree to the Developer section called
Logs
that allows users to:Extending/swapping out the LogViewer datasource
It is possible to swap out the default LogViewer datasource from reading the JSON files off disk, by disabling the Umbraco core component and registering our own component to put into the DI container.
The example below reads JSON logs stored in Azure Table Storage, that a user may configure V8 to store logs with Serilog to be logged into Azure Table storage with the off shelf Serilog sink.
Setup
Serilog.Sinks.AzureTableStorage
from Nuget (Latest pre-release)Register component (that disables the core one)
Implement ILogViewer
TODO:
Date picker range & filtering for logsRemoved for first iteration