Removing masterpages support from V8 #3971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Repository and related tests
…oving WebForms code validation / transformation
ghost
assigned 
|
Hey @callumbwhyte - thank you for all this work! We'll take a look over and let you know if we need anything. Emma |
# Conflicts: # src/Umbraco.Core/Services/Implement/PackagingService.cs # src/Umbraco.Tests/Testing/UmbracoTestBase.cs # src/Umbraco.Web/_Legacy/PackageActions/PackageHelper.cs # src/Umbraco.Web/_Legacy/PackageActions/addStringToHtmlElement.cs
|
Thank you very much @callumbwhyte - that's a great chunk of work! 🎉 Rest in peace Masterpages. You were great for a while. 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From discussions with the Core team and talks at various events I believe the interest was expressed to remove support for WebForms in Umbraco in the future. I found at various points in the V8 code relating to MasterPages that were tagged as obsolete too.
I have removed all support for MasterPages in templates, routing and in packages. This shouldn't affect any legacy WebForms stuff being used by the backoffice, just limit front-end users.
I have also removed the
defaultRenderingEnginesetting in UmbracoSettings.config as it seems now the only option would be "MVC" ... Maybe this was a move too far, I don't know if there were any plans to extend this in future, I can add it back in if needed!(sorry for the larger PR... this touched a lot of stuff!)