Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V8: Repeatable string hover + move handle styling #4389

Merged
merged 2 commits into from Feb 13, 2019

Conversation

kjac
Copy link
Contributor

@kjac kjac commented Feb 3, 2019

Prerequisites

  • I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes: #4386

Description

As #4386 points out, the hover effect for the umb-multiple-textbox "Add" link isn't consistent with the "Add" link of the treenode pickers.

As it turns out, the umb-multiple-textbox "Add" link actually inherits its styles from umb-node-preview-add (used by the treenode pickers), but the hover effect hasn't been included. This PR fixes it.

I have also added a "move" cursor effect on the move handle for the text strings, as this is also in line with the styling elsewhere.

The whole thing looks something like this:

repeatable-texts-styling

@emmaburstow
Copy link
Contributor

Dearest @kjac,

I am writing this letter to thank you sincerely for the pull request you have herein submitted. You are truly a gentleman and a scholar and we are eternally grateful for your diligence, your assiduousness and your rigour. Long may it continue.

Yours sincerely,

Emma

@kjac
Copy link
Contributor Author

kjac commented Feb 4, 2019

So let it be written, so let it be done.

Sincerely,

Kenn.

@clausjensen clausjensen merged commit 4a17702 into umbraco:temp8 Feb 13, 2019
@clausjensen
Copy link
Contributor

Thanks for the pr @kjac :)

@kjac kjac deleted the v8-fix-repeatable-string-styling branch February 13, 2019 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants