MVC 5 and WebApi 2 update #608
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ependency-Mvc with ClientDependency-Mvc5 library, fixes build issues with our view engines wrapping a view engine that no longer exists.
…t web helpers reference (not even sure why we ever had that)
…er controllers (i.e. for trees)
… (this is actually the preferred way anyways). The validation is then moved to just a filter instead of done in the model binder. This way a media formatter is pure async, so we can ReadFromStreamAsync in a completely native async operation which should hopefuly fix this issue.
…less to review and only focuses on just updating to webapi 2
Conflicts: src/Umbraco.Tests/packages.config src/Umbraco.Web.UI/packages.config src/Umbraco.Web/packages.config src/umbraco.MacroEngines/packages.config
|
@Shazwazza I've taken a checkout of your pull request and from what I can see all builds fine etc, however I am not sure if you forgot to update the nuspec files as they currently impose a requirement on having a version of MVC lower than 5, which doesn't make sense since Umbraco uses version 5.2.2 That is the only real issue I can see at the moment is a dependency version problem. |
|
Yup thanks for checking, i'll update the branch now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I previously created 2 separate PRs, one for MVC 5 and one for Web Api 2. This PR combines them both since there's no reason to upgrade one without the other since both of them require core code changes to work.
(I'll close the other 2)