parseMacroSyntax accepts other characters than a-z #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had problems with parseMacroSyntax when `syntax` included Swedish characters. Now it works with other characters than a-z as well.
|
Hi, can you please create an issue on the tracker for this ? |
|
Ok, so apparently you did not get this message. I think the issue would be this one: http://issues.umbraco.org/issue/U4-4942 |
|
I'll pull this in and test but it's worth nothing that there are 2 regex statements that must match, one for the front-end and one for the back end. I'll update. |
Shazwazza
added a commit
that referenced
this pull request
Mar 18, 2015
parseMacroSyntax accepts other characters than a-z
|
Please note I've pulled this in but will need to change the regex. We cannot allow 'any' character, it needs to be more strict otherwise we'll run into problems, things like quotes, etc... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had problems with parseMacroSyntax when
syntaxincluded Swedish characters. Now it works with other characters than a-z as well.