Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5335 - Multiple Media Picker not available as macro parameter #6149

Merged

Conversation

nul800sebastiaan
Copy link
Member

Prerequisites

  • I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes #5335

Description

Seemingly due to an oversight, multiple media picker was not available for macro parameters. This corrects that problem.

Test steps:

  • Add a Partial View Macro File from snippet "Gallery"
  • Go to the macro this has created and enable it to be used in a RTE
  • Go to the macro parameters and add a new parameter with the name "Media Picker", the alias mediaIds and of type "Multiple Media Picker"
  • Add the "Gallery" macro in a RTE
  • You get asked to pick one or more items, make sure you can pick multiple items
  • When you're done picking, the macro preview should show you the picked items

@warrenbuckley
Copy link
Contributor

Whilst I review/test this out @nul800sebastiaan can you please fix up the failing unit test :)

@warrenbuckley
Copy link
Contributor

Tested, all works 👍

@warrenbuckley warrenbuckley merged commit 445e6d4 into v8/dev Aug 21, 2019
@warrenbuckley warrenbuckley deleted the v8/feature/5335-multi-media-picker-parameter-editor branch August 21, 2019 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple Media Picker not available as macro parameter
2 participants