Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V8: Allow MNTP to pick "allowed types" for media and member pickers #6177

Merged

Conversation

kjac
Copy link
Contributor

@kjac kjac commented Aug 22, 2019

Prerequisites

  • I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes #5983

Description

This PR amends #5506 so it becomes possible to pick "allowed types" for media and member MNTP pickers. It works like this:

mntp-allowed-types-media-member

Testing this PR

  1. Make sure you can pick "allowed types" of the selected node type.
  2. When changing node type, verify that any previously selected "allowed types" are removed.

...but the resulting datatype is broken?

As it turns out, the MNTP property editor doesn't support "allowed types" for media and member (more info here). If this PR is merged in, two new issues should be created to ensure that the MNTP property editor actually works with the configured "allowed types" for media and member pickers.

@nul800sebastiaan nul800sebastiaan merged commit 6467aae into umbraco:v8/dev Sep 16, 2019
@nul800sebastiaan
Copy link
Member

Thanks very much @kjac!

Only thing to fix now is member and media type restrictions but so far so good! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants