Fix for Duplicate image src attributes in TinyMCE #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apologies for closing this pull request, I was removing branches and as this pull request was intended for the 6.1.4 branch it was automatically closed by GitHub. I'm looking into how we can re-open the pull requests that were accidentally closed. |
|
No worries, either way. I just hope that the info about why the double src attribute problem still occurs can help you guys fix it. Happy releases! 🎱 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a correction for the problem that is being discussed in the forum on Our at http://our.umbraco.org/forum/ourumb-dev-forum/bugs/39052-Duplicate-image-src-attributes
When an image could not be re-sized, its src attribute was being doubled. The attribute would be added in the catch clause of the relevant exception, and then it would also be re-added further down in the same method where the code is:
// Build image tag
foreach (var attr in allowedAttributes)
...
By commenting out the line of the catch clause which adds the src attribute, the issue has been resolved on my machine.
Please note that it is hard to reproduce this problem because the double src attribute does not actually appear in TinyMCE so there is no way to see it from there. The html source of the page needs to be reviewed.