Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the editor icon for data type trees #7373

Merged
merged 4 commits into from Dec 21, 2019
Merged

Conversation

skttl
Copy link
Contributor

@skttl skttl commented Dec 20, 2019

Prerequisites

  • I have added steps to test this contribution in the description below

Description

With the same arguments as in #7358 I would propose to use the editor icons in the data type tree. This will make it a lot easier to find data types, and make a better overview of what kind of editors you are using.

billede

To test:
Verify that the data type tree uses different icons for the data types.

@kjac
Copy link
Contributor

kjac commented Dec 21, 2019

@skttl this looks great! We'll review and get back to you 🌟

@kjac kjac changed the base branch from v8/dev to v8/contrib December 21, 2019 15:26
Copy link
Contributor

@kjac kjac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly @skttl - what a nice addition. Happy to approve 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants