Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete Stylesheet constant and references #7491

Merged

Conversation

benjaminc
Copy link
Contributor

Prerequisites

Fixes for #7368

Description

Removes an obsolete Stylesheet constant, the Stylesheet UmbracoObjectTypes enum value which used it, and references to that enum value.

@emmaburstow
Copy link
Contributor

Hey @benjaminc

Thanks for the PR tidying things up - we'll take a look and let you know if we've any questions.

Emma

Copy link
Member

@bergmania bergmania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @benjaminc...

Overall I think the PR looks good, but I think we should keep the Audit, to keep aligned with Scripts.

It IMO still make sense to have Audit on the Css files, if anyone changes these in the backoffice.

@benjaminc
Copy link
Contributor Author

benjaminc commented Feb 5, 2020

@bergmania I have merged in the changes you requested and updated the pull request.

@bergmania
Copy link
Member

@benjaminc, do you never sleep 😄

Thanks, I will merge as soon as the build server is happy :)

@bergmania bergmania merged commit 4e3980d into umbraco:netcore/dev Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants