Update DbConnectionExtensions.cs #753
Conversation
Add a log message to stop database start up code from swallowing exception messages, now stash them in the logs to give developers a chance ;)
| @@ -77,6 +77,8 @@ public static bool IsAvailable(this IDbConnection connection) | |||
| } | |||
| catch (DbException) | |||
| { | |||
| // Don't swallow this error, the exception is super handy for knowing "why" its not available | |||
| LogHelper.Info<DatabaseContext>("Configured database is reporting as not being available!", DbException ); | |||
There was a problem hiding this comment.
Perhaps you should log this as an WarnWithException, and then pass in the exception... you also need to define the exception variable... this will not build ;)
|
Just make a new commit in this branch and push it, the PR then updates automatically! |
Fixing by ham fisted cut and paste job on my log message and changing the method used to log due to Shannons feedback
Third times a charm. Lesson learn don't try to code in a RTE!
| { | ||
| // Don't swallow this error, the exception is super handy for knowing "why" its not available | ||
| LogHelper.WarnWithException<DbConnectionExtensions>("Configured database is reporting as not being available!", exc ); |
There was a problem hiding this comment.
You're missing using Umbraco.Core.Logging; 🙌
Comedy of errors. I've started doing this in the browser github editor I'm going to finish it!
|
I'm finding this quite funny to do...sorry for littering the commit history |
|
I'm giving up...and never doing this in browser again :( |
|
Well, this was the perfect opportunity for me to try and learn how to squash commits (which involved using VIM for the very first time.. whut?! 🔫) Anyway, your shame is hidden, it's all one commit now: https://github.com/umbraco/Umbraco-CMS/commits/dev-v7 |
|
Duh.. was I too hasty? haha, I'll fix it up. Browsers are for fixing spelling errors.. ;-) |
Add a log message to stop database start up code from swallowing exception messages, now stash them in the logs to give developers a chance ;)