Fixes #8433 ensures there are no write locks when updating members during login #8525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… right data applied, finishes an outstanding TODO that will massively boost performance for sites that heavily use members (lots of logins)
clausjensen
added
the
state/sprint-candidate
|
@warrenbuckley is running tests on this. I've run the unit tests and went through the code. Makes sense why this was creating unwanted locks for sites with high member activity 👍 |
nul800sebastiaan
added
release/8.6.5
type/bug
release/8.7.1
and removed
state/sprint-candidate
|
Fixed for 8.6.5, cherry picked for 8.7.1 in a2cb264 |
Shazwazza
added
the
category/performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8433
Ensures there are no write locks when updating members during login
This also finalizes an outstanding TODO that has been there for a very very long time that will hugely boost performance for sites that are membership heavy and have a lot of active logins at once. We never cached members by username but that is how they login and how they re-authenticate each request which is a huge amount of database calls.
This item has been added to our backlog AB#8415