Add images in grid - fixes 9982

[nathanwoulfe]

access control values after reassigning - check for regenerating the thumbnail needs to happen after the new value has been assigned to the control

If there's an existing issue for this PR then this fixes #9982

[nul800sebastiaan]

whoops, wrong button

Thanks @nathanwoulfe, seems like we're now missing something though, the image doesn't preview after adding it:

9987.mp4

Not sure what's not being passed back, will investigate.

[nul800sebastiaan]

$scope.control.value.image and selectedImage.image are always the same, even after picking a different image, same for $scope.control.value.focalPoint and selectedImage.focalPoint even after changing the focal point. It's because they were updated in the scope just before that, so updating the thumbnail URL needs to be done first before setting the values on the $scope.control.

[nul800sebastiaan]

I don't see a way out of this, as far as I can tell we don't have access to the values before everything changes in updateControlValue so we can't "only" do getThumnailUrl() if the value changed. I suggest always recalculating the thumbnail:

        function updateControlValue(selectedImage) {
            // we could apply selectedImage directly to $scope.control.value,
            // but this allows excluding fields in future if needed
            $scope.control.value = {
                focalPoint: selectedImage.focalPoint,
                coordinates: selectedImage.coordinates,
                id: selectedImage.id,
                udi: selectedImage.udi,
                image: selectedImage.image,
                caption: selectedImage.caption,
                altText: selectedImage.altText
            };
            $scope.thumbnailUrl = getThumbnailUrl();
        }

This works.. but it might be possible to get the old values somehow, my brain just doesn't let me see how! 😅

[nathanwoulfe]

Yeah, that makes sense - I don't think it's a huge deal regenerating the thumbnail each time. If it works, it works.

[nul800sebastiaan]

Thanks for the feedback! Fixed that one up merging now 👍

[nul800sebastiaan]

Cherry picked for 8.12.2 - e7a1db5