Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Modal Route does not support navigation with browser history #16684

Open
enkelmedia opened this issue Apr 5, 2024 · 1 comment
Open

Comments

@enkelmedia
Copy link
Contributor

enkelmedia commented Apr 5, 2024

I just notice that the behavior of the routed modal (UmbModalRouteRegistrationController) is quite strange when clicking on the "back"-button in the browser.

The route changes in the address bar and the view "behind" the modal is changing - but the modal is still on top of everything.

umb-modal-strange

In an ideal world there should be some kind of callback, like the onSetup(), onReject() to hook into the navigation and maybe prompt the user if "the thing" in the modal is not saved.

I played with some of the events from the router-slot library but the route still changed.

window.addEventListener("willchangestate", e => {

    // Check if we should navigate away from this page
    if (!confirm("You have unsaved data. Do you wish to discard it?")) {
        e.preventDefault();
        return;
    }

}, {once: true});
@iOvergaard iOvergaard transferred this issue from umbraco/Umbraco.CMS.Backoffice Jun 27, 2024
Copy link

Hi there @enkelmedia!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

  • We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
  • If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
  • We'll replicate the issue to ensure that the problem is as described.
  • We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants