Updated markup and text improvements #2018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Migaroez
commented
Oct 20, 2019
Migaroez
commented
- Pulled the markup inline with the previous tutorial page
- Added a tip for naming pages
- Added some punctuation and removed leading text to make some paragraphs easier to read.
- Pulled the markup inline with the previous tutorial page - Added a tip for naming pages - Added some punctuation and removed leading text to make some paragraphs easier to read.
sofietoft
reviewed
Oct 21, 2019
Tutorials/Creating-Basic-Site/Creating-Your-First-Template-and-Content-Node/index.md
Show resolved
Hide resolved
|
|
||
| Umbraco created this automatically when we created the **_Document Type_** (remember that option that said "..without template", we chose the one with and this is what it did). | ||
| Umbraco created this automatically when we created the **_document type_** (remember that option that said "..without template", we chose the one with and this is what it did). |
There was a problem hiding this comment.
A couple of times you've changed "Document Type" to "document type" .. as it's a concept within Umbraco, we prefer writing it with capital letters 😄
Suggested change
| Umbraco created this automatically when we created the **_document type_** (remember that option that said "..without template", we chose the one with and this is what it did). | |
| Umbraco created this automatically when we created the **_Document Type_** (remember that option that said "..without template", we chose the one with and this is what it did). |
There was a problem hiding this comment.
All concepts should be capatilized then?
Document Type
Content Node
Template
... ?
There was a problem hiding this comment.
Ah, good question!
I'd say both Document Type and Template should be capitalized.
Let's leave content node as is for now, I think!
|
@Migaroez - Did you have a chance to go through the PR here and capitalize |
|
Thanks @Migaroez 😄 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.