Update Smidge Config to reflect the UmbracoSmidgeConfigCacheBuster #3891
Conversation
|
hi @p-m-j I've just been puzzling over why the docs setting of smidge version doesn't result in a v12345 on the assets, and saw your update to the UmbracoSmidgeConfigCacheBuster - I've updated the explanation here to hopefully reflect your changes, be ace if you had a moment to cast your eye over it! |
|
Hey @marcemarc, I added some comments with my $0.02, the docs team are much better at writing style than I am so probably better to wait for their input as opposed to mine. Looks good though thanks for the PR |
|
Might be better to avoid explicit mention of smidge as its use is just an implementation detail of the umbraco RuntimeMinification abstraction. |
Co-authored-by: Paul Johnson <pmj@umbraco.com>
Co-authored-by: Paul Johnson <pmj@umbraco.com>
Co-authored-by: Paul Johnson <pmj@umbraco.com>
Thanks @p-m-j! - will revert to the docs team! they do an awesome job... |
| "CacheBuster": "Version", | ||
| "Version": "1234" | ||
| } | ||
| } | ||
| } | ||
| ``` | ||
| The actual 'Version' number will not be visible in the url of the assets, this is because it is combined, along with the Umbraco Version from configuration and the your project assembly dll, and then once combined a 'hash' is generated to obscure these details. | ||
|
|
||
| in the HTML link thus: ```<link href='/sc/69a3dbf6.1cf661e7.css.d=efb7329470a16d7020272a294742726ebe1da5f1' rel='stylesheet' type='text/css'/>``` |
There was a problem hiding this comment.
Using Version cache buster the output in v9.4.1 is like this
<link href='/sb/umbraco-backoffice-init-css.css.v7a71f91360259c5f7c3337f152b0df01eeee36f0' rel='stylesheet' type='text/css'/>
There was a problem hiding this comment.
This changes based on the value of Hosting:Debug.
I'm not sure the emphasis on the hash appearing is useful as long as users are aware of when then cache busting takes place.
However I do wonder if we should change the value to be {{hash}}.{{configured explicit version value}} so the value from config shows in the URL to avoid confusion.
There was a problem hiding this comment.
However I do wonder if we should change the value to be {{hash}}.{{configured explicit version value}} so the value from config shows in the URL to avoid confusion.
I think this makes sense!
There was a problem hiding this comment.
However I do wonder if we should change the value to be {{hash}}.{{configured explicit version value}} so the value from config shows in the URL to avoid confusion.
Yes, great observation! - it's the 'setting' of an explicit version in the appsettings configuration that then doesn't translate to what's seen on the asset URLs, that causes confusion!
|
@p-m-j whilst figuring this out with @marcemarc it has also occurred to me that I think Umbraco should be setting the Smidge dataFolder to the Umbraco Temp or at least providing the option to set it, what do you think? |
|
@Jeavon I think that's already covered although perhaps it could be clearer, see final paragraph on RuntimeMinificationSettings |
|
@p-m-j but setting dataFolder to a path isn't going to observe the LocalTempStorageLocation setting which I think you should be able to do. Perhaps can be done in code... |
|
Ahh I see what you mean, sounds like a good idea, also useful for working towards supporting WEBSITE_RUN_FROM_PACKAGE |
Very true! I had a quick try at setting it in code but couldn't get it swapped in time so I think should be added into Umbraco |
Sorry for the whitespace I just want to check that Vale Linter is still running
|
Hi @Jeavon and @marcemarc .. What's the status on this PR - except for the fact that there are merge conflicts? |
# Conflicts: # Reference/Configuration/RuntimeMinificationSettings/index.md
|
@p-m-j do you have a note about setting Smidge to observe LocalTempStorageLocation or should I raise a CMS issue? |
No description provided.