Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rerouted from temp-dev to research dev, built-in AccessFrom to cluster to prevent ssh access from everywhere #69

Merged
merged 3 commits into from
Sep 2, 2020

Conversation

alexiswl
Copy link
Member

@alexiswl alexiswl commented Sep 1, 2020

Start_cluster:
Uses AccessFrom to users local IP to restrict access to the cluster from ssh to just them. More for security checks, we don't use ssh access anyway.

Readme:
Added in SSO login issues whilst in pcluster env

All other file changes due to redirection of config files to a new s3 bucket.

Start_cluster:
Uses AccessFrom to users local IP to restrict access to the cluster from ssh to just them. More for security checks, we don't use ssh access anyway.

Readme:
Added in SSO login issues whilst in pcluster env

All other file changes due to redirection of config files to a new s3 bucket.
@alexiswl
Copy link
Member Author

alexiswl commented Sep 1, 2020

Not sure this AccessFrom is working though.

It's present here as a parameter of the Cloud Formation Stack:
image

But contradicts itself here in the security group settings:
image

parallel_cluster/bin/start_cluster.sh Show resolved Hide resolved
parallel_cluster/conf/config Show resolved Hide resolved

# FIXME: control error codes better, avoiding counterintuitive ones: i.e authed within a different account:
# ERROR: The configuration parameter 'vpc_id' generated the following errors:
# The vpc ID 'vpc-7d2b2e1a' does not exist
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does that copy-pasted VPC error come from? :-S

Also, the code above makes it seem like that error management is solved?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a dev user runs through the Tothill account, I don't have access to that VPC.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is still on the TODO list, or maybe I write something up in the troubleshooting section of the Readme.
I just started the download of the gridss hg38 refdata into an efs system and regretting not prioritising that as a morning task so now looking for things to do...

… Place additional errors in the readme rather than try control them from the script.
@alexiswl
Copy link
Member Author

alexiswl commented Sep 1, 2020

Not sure this AccessFrom is working though.

It's present here as a parameter of the Cloud Formation Stack:
image

But contradicts itself here in the security group settings:
image

This has been resolved in 3e95d38 with @victorskl suggestion

@brainstorm brainstorm merged commit f8e4caa into master Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants