Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Init CDK-Pipeline #24

Merged
merged 14 commits into from
Jun 1, 2023
Merged

Init CDK-Pipeline #24

merged 14 commits into from
Jun 1, 2023

Conversation

williamputraintan
Copy link
Member

@williamputraintan williamputraintan commented May 30, 2023 •
edited
Loading

  • Update cdk to 2.81 due to issue
  • Add CDK-Pipeline (with some UnitTest in CodeBuildStep)
  • Some refactoring on defining the Stack Props

@williamputraintan williamputraintan marked this pull request as ready for review May 30, 2023 06:04
@victorskl
Copy link
Member

Thanks Will; reviewing soon this

@victorskl victorskl added this to the Release 0.1.0 milestone May 31, 2023
@victorskl
Copy link
Member

Orcabus V1: Implement baseline CDK Pipeline

victorskl
victorskl approved these changes Jun 1, 2023
View reviewed changes
Copy link
Member

@victorskl victorskl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Had a few questions but early days. So, let us push it ahead.
Please squash merge.
Tq

test/workload/stateful/SecurityGroupConstruct.test.ts Outdated
});
});

test('Test SchemaRegistry Creation', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff, Will!

@williamputraintan williamputraintan merged commit 5281a9a into main Jun 1, 2023
@williamputraintan williamputraintan deleted the cdk-pipeline branch June 1, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorskl victorskl victorskl approved these changes

@reisingerf reisingerf reisingerf approved these changes

Assignees

@williamputraintan williamputraintan

Labels
devops feature New feature platform
Projects
None yet
Milestone
Release 0.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@williamputraintan @victorskl @reisingerf