This repository has been archived by the owner on Dec 13, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 33
Adding in Base Processor - exposing Umbraco context services #204
Merged
leekelleher
merged 14 commits into
umco:feature/umbraco-context
from
jamiepollock:develop
Feb 10, 2017
Merged
Adding in Base Processor - exposing Umbraco context services #204
leekelleher
merged 14 commits into
umco:feature/umbraco-context
from
jamiepollock:develop
Feb 10, 2017
Commits on Jan 20, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 28581a1 - Browse repository at this point
Copy the full SHA 28581a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9b2b4bb - Browse repository at this point
Copy the full SHA 9b2b4bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a8ff0e - Browse repository at this point
Copy the full SHA 6a8ff0eView commit details -
Configuration menu - View commit details
-
Copy full SHA for e25d132 - Browse repository at this point
Copy the full SHA e25d132View commit details
Commits on Jan 22, 2017
-
Rewrite of use of UmbracoContext & ApplicationContext (See description)
Based on the idea of https://github.com/umbraco/Umbraco-CMS/blob/release-7.3.2/src/Umbraco.Web/IUmbracoContextAccessor.cs & https://github.com/umbraco/Umbraco-CMS/blob/release-7.3.2/src/Umbraco.Web/SingletonUmbracoContextAccessor.cs I've implemented an "UmbracoApplicationContextAccessor which allows readonly access to the UmbracoContext & ApplicationContext. In most cases this will use the SingletonUmbracoApplicationContextAccessor but in the case of tests there is a publicly available static register method to setup an alternative which used a mocked version of this accessor. Not happy about the accessor being passed through so many properties but it's the best way I can think of to ensure we're using exactly the same contexts from method to method.
Configuration menu - View commit details
-
Copy full SHA for bd4c79a - Browse repository at this point
Copy the full SHA bd4c79aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4adf7a7 - Browse repository at this point
Copy the full SHA 4adf7a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for e3093b5 - Browse repository at this point
Copy the full SHA e3093b5View commit details
Commits on Jan 23, 2017
-
Merge remote-tracking branch 'refs/remotes/upstream/develop'
Conflicts: src/Our.Umbraco.Ditto/Extensions/PublishedContentExtensions.cs
Configuration menu - View commit details
-
Copy full SHA for 984b940 - Browse repository at this point
Copy the full SHA 984b940View commit details -
Configuration menu - View commit details
-
Copy full SHA for e83e19d - Browse repository at this point
Copy the full SHA e83e19dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9558b02 - Browse repository at this point
Copy the full SHA 9558b02View commit details
Commits on Jan 24, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 1994996 - Browse repository at this point
Copy the full SHA 1994996View commit details
Commits on Jan 25, 2017
-
Crusade against UmbracoContext, DictionaryHelper removed (see desc)
Removed the static class, UmbracoDictionaryHelper. Tentatively added in UmbracoHelper instance as in Umbraco v7.3.2 this is the best way to get a dictionary value. Also worked in some teardowns for Resolution.Reset() so tests work between this and the UmbracoPicker tests. Finally, there's a slight change to the dictionary tests as UmbracoHelper.GetDictionaryValue doesn't do an ordinal key check for keys. Not sure how we can fix this within Ditto, it might be a feature Umbraco adds in later on.
Configuration menu - View commit details
-
Copy full SHA for e2d0f4f - Browse repository at this point
Copy the full SHA e2d0f4fView commit details -
Merge remote-tracking branch 'refs/remotes/upstream/develop'
Conflicts: src/Our.Umbraco.Ditto/Extensions/PublishedContentExtensions.cs tests/Our.Umbraco.Ditto.Tests/Our.Umbraco.Ditto.Tests.csproj
Configuration menu - View commit details
-
Copy full SHA for 10736b1 - Browse repository at this point
Copy the full SHA 10736b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0163d2c - Browse repository at this point
Copy the full SHA 0163d2cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.