Skip to content
This repository has been archived by the owner on Dec 13, 2021. It is now read-only.

Adding in Base Processor - exposing Umbraco context services #204

Merged
merged 14 commits into from
Feb 10, 2017

Commits on Jan 20, 2017

  1. Configuration menu
    Copy the full SHA
    28581a1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9b2b4bb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6a8ff0e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e25d132 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2017

  1. Rewrite of use of UmbracoContext & ApplicationContext (See description)

    Based on the idea of https://github.com/umbraco/Umbraco-CMS/blob/release-7.3.2/src/Umbraco.Web/IUmbracoContextAccessor.cs & https://github.com/umbraco/Umbraco-CMS/blob/release-7.3.2/src/Umbraco.Web/SingletonUmbracoContextAccessor.cs
    
    I've implemented an "UmbracoApplicationContextAccessor which allows readonly access to the UmbracoContext & ApplicationContext. In most cases this will use the SingletonUmbracoApplicationContextAccessor but in the case of tests there is a publicly available static register method to setup an alternative which used a mocked version of this accessor.
    
    Not happy about the accessor being passed through so many properties but it's the best way I can think of to ensure we're using exactly the same contexts from method to method.
    jamiepollock committed Jan 22, 2017
    Configuration menu
    Copy the full SHA
    bd4c79a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4adf7a7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e3093b5 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2017

  1. Merge remote-tracking branch 'refs/remotes/upstream/develop'

    Conflicts:
    	src/Our.Umbraco.Ditto/Extensions/PublishedContentExtensions.cs
    jamiepollock committed Jan 23, 2017
    Configuration menu
    Copy the full SHA
    984b940 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e83e19d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9558b02 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2017

  1. Configuration menu
    Copy the full SHA
    1994996 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2017

  1. Crusade against UmbracoContext, DictionaryHelper removed (see desc)

    Removed the static class, UmbracoDictionaryHelper.
    
    Tentatively added in UmbracoHelper instance as in Umbraco v7.3.2 this is the best way to get a dictionary value.
    
    Also worked in some teardowns for Resolution.Reset() so tests work between this and the UmbracoPicker tests.
    
    Finally, there's a slight change to the dictionary tests as UmbracoHelper.GetDictionaryValue doesn't do an ordinal key check for keys. Not sure how we can fix this within Ditto, it might be a feature Umbraco adds in later on.
    jamiepollock committed Jan 25, 2017
    Configuration menu
    Copy the full SHA
    e2d0f4f View commit details
    Browse the repository at this point in the history
  2. Merge remote-tracking branch 'refs/remotes/upstream/develop'

    Conflicts:
    	src/Our.Umbraco.Ditto/Extensions/PublishedContentExtensions.cs
    	tests/Our.Umbraco.Ditto.Tests/Our.Umbraco.Ditto.Tests.csproj
    jamiepollock committed Jan 25, 2017
    Configuration menu
    Copy the full SHA
    10736b1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0163d2c View commit details
    Browse the repository at this point in the history