Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement MaxSupplyUtilization #1330

Merged
merged 10 commits into from
Sep 6, 2022
Merged

feat: implement MaxSupplyUtilization #1330

merged 10 commits into from
Sep 6, 2022

Conversation

toteki
Copy link
Member

@toteki toteki commented Sep 5, 2022

Description

closes: #1162


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@toteki toteki marked this pull request as ready for review September 5, 2022 02:33
@toteki toteki requested review from a team as code owners September 5, 2022 02:33
@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2022

Codecov Report

Merging #1330 (fc5b041) into adam/c1 (2f812a4) will increase coverage by 0.06%.
The diff coverage is 78.57%.

Impacted file tree graph

@@             Coverage Diff             @@
##           adam/c1    #1330      +/-   ##
===========================================
+ Coverage    51.88%   51.94%   +0.06%     
===========================================
  Files           69       69              
  Lines         6748     6770      +22     
===========================================
+ Hits          3501     3517      +16     
- Misses        2976     2980       +4     
- Partials       271      273       +2     
Impacted Files Coverage Δ
x/leverage/keeper/keeper.go 65.23% <50.00%> (-0.89%) ⬇️
x/leverage/keeper/borrows.go 79.09% <100.00%> (ø)
x/leverage/keeper/grpc_query.go 63.44% <100.00%> (+2.29%) ⬆️

@toteki toteki changed the base branch from main to adam/c1 September 5, 2022 04:45
@toteki
Copy link
Member Author

toteki commented Sep 5, 2022

Note: Merge #1329 before this

@toteki toteki mentioned this pull request Sep 5, 2022
17 tasks
Copy link
Member

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

x/leverage/keeper/borrows.go Outdated Show resolved Hide resolved
x/leverage/keeper/keeper.go Show resolved Hide resolved
Base automatically changed from adam/c1 to main September 6, 2022 18:50
@mergify mergify bot merged commit f7888b1 into main Sep 6, 2022
@mergify mergify bot deleted the adam/c2 branch September 6, 2022 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

leverage: implement MaxSupplyUtilization restriction
4 participants