Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Use --from flag on all leverage CLI and remove first addr argument #1333

Merged
merged 1 commit into from
Sep 5, 2022

Conversation

toteki
Copy link
Member

@toteki toteki commented Sep 5, 2022

Description

closes: #1205


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@toteki toteki marked this pull request as ready for review September 5, 2022 05:56
@toteki toteki requested review from a team as code owners September 5, 2022 05:56
@codecov-commenter
Copy link

Codecov Report

Merging #1333 (12dee1e) into main (06424cd) will increase coverage by 0.14%.
The diff coverage is 53.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1333      +/-   ##
==========================================
+ Coverage   51.65%   51.80%   +0.14%     
==========================================
  Files          68       68              
  Lines        6870     6669     -201     
==========================================
- Hits         3549     3455      -94     
+ Misses       3063     2947     -116     
- Partials      258      267       +9     
Impacted Files Coverage Δ
x/ibctransfer/keeper/keeper.go 0.00% <ø> (ø)
x/leverage/client/cli/tx.go 0.00% <0.00%> (ø)
x/leverage/keeper/msg_server.go 1.17% <0.00%> (+0.35%) ⬆️
x/leverage/types/tx.go 0.00% <0.00%> (ø)
x/oracle/types/keys.go 100.00% <ø> (ø)
x/oracle/types/msgs.go 90.21% <0.00%> (-3.47%) ⬇️
x/leverage/keeper/exchange_rate.go 72.72% <12.50%> (ø)
x/leverage/keeper/oracle.go 60.29% <25.00%> (-7.28%) ⬇️
x/leverage/keeper/token.go 74.19% <50.00%> (-2.48%) ⬇️
x/leverage/types/token.go 72.52% <50.00%> (ø)
... and 23 more

@RafilxTenfen RafilxTenfen merged commit 87a83a9 into main Sep 5, 2022
@RafilxTenfen RafilxTenfen deleted the adam/from branch September 5, 2022 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI commands should be less ambigous with respect to --from and sender
4 participants