Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(price-feeder): add mexc provider #1339

Merged
merged 20 commits into from
Sep 15, 2022
Merged

feat(price-feeder): add mexc provider #1339

merged 20 commits into from
Sep 15, 2022

Conversation

adamewozniak
Copy link
Collaborator

Adds the mexc provider 🚀


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Copy link
Member

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer if we focus with all team towards beta release.

  • QA are not done, and we need to do more crash tests of the oracle.
  • we can always add new provider once we have chain RC.
  • we also need support with liveness tests.

So if not a problem - can we push back finalization of this task for later, until we have RC?

price-feeder/oracle/provider/mexc.go Show resolved Hide resolved
price-feeder/oracle/provider/mexc.go Show resolved Hide resolved
price-feeder/oracle/provider/mexc.go Show resolved Hide resolved
price-feeder/oracle/provider/mexc.go Outdated Show resolved Hide resolved
price-feeder/oracle/provider/mexc.go Outdated Show resolved Hide resolved
price-feeder/oracle/provider/mexc.go Outdated Show resolved Hide resolved
price-feeder/oracle/provider/mexc.go Outdated Show resolved Hide resolved
price-feeder/oracle/provider/mexc.go Outdated Show resolved Hide resolved
price-feeder/oracle/provider/mexc.go Show resolved Hide resolved
price-feeder/oracle/provider/mexc.go Outdated Show resolved Hide resolved
@RafilxTenfen
Copy link
Contributor

I saw that this provider has Umee prices, but when I tried to put it in the config to get prices "UMEEUSDT" but I keep receiving

10:09PM INF skipping until next voting period current_vote_period=5 module=oracle previous_vote_period=5 vote_period=5
10:09PM ERR failed to get ticker prices from provider error="mexc failed to get candle price for UMEE_USDT" module=oracle

This is because no one traded umee?

Copy link
Contributor

@RafilxTenfen RafilxTenfen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Only question about umee prices in mexc provider

@adamewozniak
Copy link
Collaborator Author

I saw that this provider has Umee prices, but when I tried to put it in the config to get prices "UMEEUSDT" but I keep receiving


10:09PM INF skipping until next voting period current_vote_period=5 module=oracle previous_vote_period=5 vote_period=5

10:09PM ERR failed to get ticker prices from provider error="mexc failed to get candle price for UMEE_USDT" module=oracle

This is because no one traded umee?

Yeah, this'll happen if there's 0 volume for a given pair over the last 3 minutes. Did you test with another pair @RafilxTenfen ?

@RafilxTenfen
Copy link
Contributor

I saw that this provider has Umee prices, but when I tried to put it in the config to get prices "UMEEUSDT" but I keep receiving


10:09PM INF skipping until next voting period current_vote_period=5 module=oracle previous_vote_period=5 vote_period=5

10:09PM ERR failed to get ticker prices from provider error="mexc failed to get candle price for UMEE_USDT" module=oracle

This is because no one traded umee?

Yeah, this'll happen if there's 0 volume for a given pair over the last 3 minutes. Did you test with another pair @RafilxTenfen ?

Yes, ATOMUSDT worked

@mergify mergify bot merged commit d5f1a67 into main Sep 15, 2022
@mergify mergify bot deleted the woz/mexc-provider branch September 15, 2022 18:16
mergify bot pushed a commit that referenced this pull request Sep 15, 2022
Adds the mexc provider 🚀

---

### Author Checklist

_All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues._

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] added appropriate labels to the PR
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/umee-network/umee/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

_All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items._

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed all author checklist items have been addressed
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)

(cherry picked from commit d5f1a67)
facundomedica pushed a commit that referenced this pull request Sep 15, 2022
Adds the mexc provider 🚀

---

### Author Checklist

_All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues._

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] added appropriate labels to the PR
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/umee-network/umee/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

_All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items._

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed all author checklist items have been addressed
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)

(cherry picked from commit d5f1a67)
adamewozniak added a commit that referenced this pull request Sep 15, 2022
Adds the mexc provider 🚀

---

### Author Checklist

_All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues._

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] added appropriate labels to the PR
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/umee-network/umee/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

_All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items._

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed all author checklist items have been addressed
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)

(cherry picked from commit d5f1a67)

Co-authored-by: Adam Wozniak <29418299+adamewozniak@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants