Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 4.1 BNB migration #1807

Merged
merged 19 commits into from
Feb 14, 2023
Merged

fix: 4.1 BNB migration #1807

merged 19 commits into from
Feb 14, 2023

Conversation

toteki
Copy link
Member

@toteki toteki commented Feb 13, 2023

This will switch the BNB ibc denom in the leverage registry and oracle accept list to the correct denom.

@toteki toteki added T:Bug A regression or bug in the Umee codebase. C:x/leverage C:x/oracle labels Feb 13, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #1807 (e6c1329) into main (7c04da0) will decrease coverage by 0.19%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1807      +/-   ##
==========================================
- Coverage   57.80%   57.62%   -0.19%     
==========================================
  Files          78       79       +1     
  Lines        8023     8049      +26     
==========================================
  Hits         4638     4638              
- Misses       3047     3073      +26     
  Partials      338      338              
Impacted Files Coverage Δ
x/leverage/keeper/migrations.go 0.00% <0.00%> (ø)
x/oracle/keeper/migrations.go 11.11% <0.00%> (-3.18%) ⬇️

@toteki toteki marked this pull request as ready for review February 13, 2023 05:48
@toteki toteki requested review from a team as code owners February 13, 2023 05:48
Copy link
Collaborator

@gsk967 gsk967 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check the error code and github lints

x/leverage/types/errors.go Outdated Show resolved Hide resolved
x/oracle/keeper/migrations.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@gsk967 gsk967 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should avoid growing the keeper package.

x/leverage/keeper/migrations.go Show resolved Hide resolved
@mergify mergify bot merged commit 0e4df51 into main Feb 14, 2023
@mergify mergify bot deleted the adam/bnb branch February 14, 2023 13:11
mergify bot pushed a commit that referenced this pull request Feb 14, 2023
This will switch the BNB ibc denom in the leverage registry and oracle accept list to the correct denom.

(cherry picked from commit 0e4df51)

# Conflicts:
#	app/upgrades.go
#	x/leverage/keeper/internal_test.go
toteki added a commit that referenced this pull request Feb 14, 2023
* fix: 4.1 BNB migration (#1807)

This will switch the BNB ibc denom in the leverage registry and oracle accept list to the correct denom.

(cherry picked from commit 0e4df51)

# Conflicts:
#	app/upgrades.go
#	x/leverage/keeper/internal_test.go

* fix conficts

---------

Co-authored-by: Adam Moser <63419657+toteki@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants