fix: collateral share restriction works during partial price outages #1812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1812 +/- ##
==========================================
+ Coverage 57.79% 57.92% +0.12%
==========================================
Files 78 78
Lines 8026 8049 +23
==========================================
+ Hits 4639 4662 +23
Misses 3049 3049
Partials 338 338
|
toteki
pushed a commit
that referenced
this pull request
Feb 14, 2023
This was referenced Apr 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When some token prices are missing from the oracle, it becomes impossible to calculate a token's collateral share.
However, if the collateralized token's price is known, and enough other token prices are known to prove that it cannot possibly be over its
MaxCollateralShare, then we can letMsgSupplyCollateralorMsgCollateralizesucceed anyway.