(test): improve IBC check in e2e tests #2558
Conversation
WalkthroughThese changes enhance the Changes
Sequence Diagram(s)sequenceDiagram
participant A as E2ETestSuite
participant B as s.SendIBC
participant C as IBC Transfer Handler
participant D as Logger
A->>B: Call s.SendIBC with params including expectedErr
B->>C: Execute IBC Transfer
C->>B: Return result or error
B-->>D: Log result based on expectedErr
B->>A: Return result to E2ETestSuite
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2558 +/- ##
===========================================
- Coverage 75.38% 62.77% -12.62%
===========================================
Files 100 275 +175
Lines 8025 15969 +7944
===========================================
+ Hits 6050 10024 +3974
- Misses 1589 5171 +3582
- Partials 386 774 +388 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (2)
tests/e2e/e2e_ibc_test.go (1)
31-31: The new constanterrQuotaExceedshould be documented to explain its usage and significance.tests/e2e/setup/utils.go (1)
Line range hint
58-135: Review the modifications to theSendIBCfunction to ensure they align with the new error handling requirements and that the retry logic is robust.Consider adding more detailed logging and possibly separating the command construction from the execution logic to enhance readability and maintainability.
+ // Detailed logging for each step + s.T().Logf("Constructing command for IBC transfer...") - // retry up to 5 times + // Retry logic separated for clarity + retryCommand := func(cmd []string) { + for i := 0; i < 5; i++ { + if i > 0 { + s.T().Logf("...retry %d", i+1) + } + executeCommand(cmd) + } + } + retryCommand(cmd)
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- tests/e2e/e2e_ibc_memo_test.go (3 hunks)
- tests/e2e/e2e_ibc_test.go (6 hunks)
- tests/e2e/setup/utils.go (2 hunks)
Additional comments not posted (4)
tests/e2e/e2e_ibc_memo_test.go (3)
85-85: Validate that theSendIBCfunction is called correctly with the serialized memo JSON.
47-47: Ensure proper handling of the empty string for error scenarios in theSendIBCfunction call.
63-63: Ensure that theSendIBCfunction is called with correct parameters, especially the empty strings for memo and error.tests/e2e/e2e_ibc_test.go (1)
141-141: Confirm that allSendIBCfunction calls are updated according to the new signature and are handling errors correctly.Also applies to: 150-150, 166-166, 174-175, 182-182, 189-190, 197-197, 204-204, 215-215, 219-219, 272-272
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- tests/e2e/setup/utils.go (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- tests/e2e/setup/utils.go
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- tests/e2e/setup/utils.go (3 hunks)
Files skipped from review as they are similar to previous changes (1)
- tests/e2e/setup/utils.go
Description
Summary by CodeRabbit