Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: price-feeder: add missing candles warning #625

Merged
merged 4 commits into from
Mar 8, 2022

Conversation

adamewozniak
Copy link
Collaborator

Description

Add an error message on pairs for which we could not get candles.

closes: #619


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added appropriate labels to the PR
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@adamewozniak adamewozniak marked this pull request as ready for review March 8, 2022 18:45
@adamewozniak adamewozniak changed the title feat: add missing candles warning feat: price-feeder: add missing candles warning Mar 8, 2022
@alexanderbez alexanderbez merged commit 36ed909 into main Mar 8, 2022
@alexanderbez alexanderbez deleted the woz/missing-candles-warning branch March 8, 2022 22:15
mergify bot pushed a commit that referenced this pull request Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

price-feeder: update missing prices warning for candles
2 participants