Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: provider timeouts #679

Merged
merged 4 commits into from
Mar 24, 2022
Merged

feat: provider timeouts #679

merged 4 commits into from
Mar 24, 2022

Conversation

adamewozniak
Copy link
Collaborator

Description

Necessary feature for non-websocket providers that take long enough to retrieve prices that it disrupts the voting mechanism, causing periodic loss of exchange rates & missed vote periods for validators.

closes: #674


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added appropriate labels to the PR
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@adamewozniak adamewozniak changed the title feat: timeout providers that take longer than 100ms feat: timeout providers after 100ms Mar 24, 2022
@adamewozniak
Copy link
Collaborator Author

adamewozniak commented Mar 24, 2022

Need to ignore this for the mock provider, which can take up to 1.8s apparently - no clean way to do this inline, so going to have to make this a part of the config

@adamewozniak adamewozniak marked this pull request as draft March 24, 2022 04:53
@adamewozniak adamewozniak marked this pull request as ready for review March 24, 2022 05:40
@adamewozniak adamewozniak changed the title feat: timeout providers after 100ms feat: provider timeouts Mar 24, 2022
Copy link
Member

@toteki toteki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making it part of config might help in the long run anyway, so that works

@adamewozniak adamewozniak merged commit 2a69b56 into main Mar 24, 2022
@adamewozniak adamewozniak deleted the woz/pf/provider-timeout branch March 24, 2022 14:42
mergify bot pushed a commit that referenced this pull request Mar 24, 2022
(cherry picked from commit 2a69b56)
adamewozniak added a commit that referenced this pull request Mar 24, 2022
(cherry picked from commit 2a69b56)

Co-authored-by: Adam Wozniak <29418299+adamewozniak@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

price-feeder: occasional missed votes
2 participants