Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add param SmallLiquidationSize #723

Merged
merged 7 commits into from
Mar 30, 2022
Merged

feat: add param SmallLiquidationSize #723

merged 7 commits into from
Mar 30, 2022

Conversation

toteki
Copy link
Member

@toteki toteki commented Mar 29, 2022

Description

If a borrower's borrowed value (in USD) is lower than this sdk.Dec parameter, their CloseFactor will be 1.0 once they are eligible for liquidation.

Thus, "small" borrows abandoned by their users are not chipped away at forever by ~1% MinimumCloseFactor liquidations, never reaching zero, but can instead by finished off.

The default SmallLiquidationSize is $100.00


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added appropriate labels to the PR
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

x/leverage/spec/07_params.md Outdated Show resolved Hide resolved
@RafilxTenfen
Copy link
Contributor

Weird, protobuf is also failing at main

cc @adamewozniak @toteki

@adamewozniak
Copy link
Collaborator

Weird, protobuf is also failing at main

cc @adamewozniak @toteki

Afaik that test has been failing if there are any protobuff changes for a while - we should definitely fix it, but shouldn't be a problem in this PR

Copy link
Collaborator

@adamewozniak adamewozniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀

x/leverage/keeper/keeper.go Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
toteki and others added 3 commits March 30, 2022 08:31
Co-authored-by: Adam Wozniak <29418299+adamewozniak@users.noreply.github.com>
@adamewozniak adamewozniak merged commit d9903f7 into main Mar 30, 2022
@adamewozniak adamewozniak deleted the adam/minimum branch March 30, 2022 15:53
mergify bot pushed a commit that referenced this pull request Mar 30, 2022
toteki added a commit that referenced this pull request Mar 30, 2022
(cherry picked from commit d9903f7)

Co-authored-by: Adam Moser <63419657+toteki@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants