feat: update gravity bridge to v1.5.0 + upgrade handler for Calypso (v2.0.0) #729

facundomedica · 2022-03-31T17:44:03Z

Description

Upgrade to Gravity Bridge v1.5.0
Add upgrade handlers to do the Calypso update (Leverage and oracle modules)
While I was at it I added the option to run tests with Ganache instead of geth, pretty helpful when running on Mac M1

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

confirmed the correct type prefix in the PR title
confirmed ! in the type prefix if API or client breaking change
confirmed all author checklist items have been addressed
reviewed state machine logic
reviewed API design and naming
reviewed documentation is accurate
reviewed tests and test coverage
manually tested (if applicable)

…into facu/upgrade-gb

toteki · 2022-04-02T03:09:53Z

It does seem to avoid importing ibc-go so it's probably not a problem. I was looking at the go.mod over at bech32ibc to see what it's doing roughly.

adamewozniak

Left a few small suggestions 😄

app/app.go

app/upgrades/calypso/handler.go

app/upgrades/register.go

app/upgrades/calypso/handler.go

toteki

Agree on removing any print lines as long as we log.Info all the important stuff. I'll run a test upgrade locally with this then drop an approval once it works on my machine.

Co-authored-by: Adam Wozniak <29418299+adamewozniak@users.noreply.github.com>

…into facu/upgrade-gb

toteki

working, it seems to be
merge, we should

adamewozniak

A couple nits but LGTM

app/app.go

…v2.0.0) (#729) ## Description - Upgrade to Gravity Bridge v1.5.0 - Add upgrade handlers to do the Calypso update (Leverage and oracle modules) - While I was at it I added the option to run tests with Ganache instead of geth, pretty helpful when running on Mac M1 ---- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added appropriate labels to the PR - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/umee-network/umee/blob/main/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit 3b596e0) # Conflicts: # price-feeder/go.mod # price-feeder/go.sum

…v2.0.0) (backport #729) (#736) * feat: update gravity bridge to v1.5.0 + upgrade handler for Calypso (v2.0.0) (#729) ## Description - Upgrade to Gravity Bridge v1.5.0 - Add upgrade handlers to do the Calypso update (Leverage and oracle modules) - While I was at it I added the option to run tests with Ganache instead of geth, pretty helpful when running on Mac M1 ---- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added appropriate labels to the PR - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/umee-network/umee/blob/main/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit 3b596e0) # Conflicts: # price-feeder/go.mod # price-feeder/go.sum * fix conflict issue * piggyback other go.mod backports (prometheus, toml) Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com> Co-authored-by: RafilxTenfen <rafaeltenfen.rt@gmail.com> Co-authored-by: toteki <63419657+toteki@users.noreply.github.com> Co-authored-by: Adam Wozniak <29418299+adamewozniak@users.noreply.github.com>

update gravity bridge to v1.5.0 + add missing keepers

67614bc

facundomedica requested a review from a team as a code owner March 31, 2022 17:44

facundomedica changed the title ~~update gravity bridge to v1.5.0 + add missing keepers~~ [WIP] update gravity bridge to v1.5.0 + add missing keepers + upgrade handler Mar 31, 2022

facundomedica changed the title ~~[WIP] update gravity bridge to v1.5.0 + add missing keepers + upgrade handler~~ feat: [WIP] update gravity bridge to v1.5.0 + add missing keepers + upgrade handler Mar 31, 2022

facundomedica added 19 commits March 31, 2022 14:53

fix order

08cb0b0

fix gb price-feeder

1155c26

fix gb price-feeder

357b6bc

fix

5de05de

fix

6be3bfe

fix

5ea1ea3

fix

67bdf91

fix

2f9f180

fix

b4d321b

try to fix

5169ac0

try to fix

a43e48d

try to fix

bbbcce8

try to fix

e8b5422

finally fixed

31b25c5

finally fixed 2

94d167b

add calypso update handler

d5f37d1

add calypso update handler

6dc6d46

lint

3f8a252

lint

243db0c

facundomedica changed the title ~~feat: [WIP] update gravity bridge to v1.5.0 + add missing keepers + upgrade handler~~ feat: [WIP] update gravity bridge to v1.5.0 + add missing keepers + upgrade handler for Calypso (v2.0.0) Apr 1, 2022

facundomedica and others added 3 commits April 1, 2022 22:31

Merge branch 'main' into facu/upgrade-gb

d8942c2

fix peggo version to v0.3.0

ede425e

Merge branch 'facu/upgrade-gb' of https://github.com/umee-network/umee …

e5b7c10

…into facu/upgrade-gb

facundomedica changed the title ~~feat: [WIP] update gravity bridge to v1.5.0 + add missing keepers + upgrade handler for Calypso (v2.0.0)~~ feat: [WIP] update gravity bridge to v1.5.0 + upgrade handler for Calypso (v2.0.0) Apr 1, 2022

facundomedica changed the title ~~feat: [WIP] update gravity bridge to v1.5.0 + upgrade handler for Calypso (v2.0.0)~~ feat: update gravity bridge to v1.5.0 + upgrade handler for Calypso (v2.0.0) Apr 1, 2022

facundomedica added the S:backport/v2.x.x label Apr 1, 2022

adamewozniak reviewed Apr 2, 2022

View reviewed changes

toteki added C:x/leverage C:x/oracle labels Apr 2, 2022

toteki reviewed Apr 3, 2022

View reviewed changes

facundomedica and others added 15 commits April 4, 2022 14:51

Update app/upgrades/calypso/handler.go

86be30d

Co-authored-by: Adam Wozniak <29418299+adamewozniak@users.noreply.github.com>

Update app/upgrades/register.go

249587c

Co-authored-by: Adam Wozniak <29418299+adamewozniak@users.noreply.github.com>

Update app/upgrades/calypso/handler.go

d0d6810

Co-authored-by: Adam Wozniak <29418299+adamewozniak@users.noreply.github.com>

remove unnecessary bits

2ea4bd2

Merge branch 'facu/upgrade-gb' of https://github.com/umee-network/umee …

536d492

…into facu/upgrade-gb

remove unnecessary bits

da93ffe

stop using pointer for stakingkeeper

eb5679f

stop using pointer for stakingkeeper

32c762f

stop using pointer for stakingkeeper test

5aa7971

stop using pointer for stakingkeeper test

d5fbcd6

stop using pointer for stakingkeeper test

ac9c543

stop using pointer for stakingkeeper test

48c88c6

stop using pointer for stakingkeeper test

86b0e22

if this works I get to drink a beer even tho today it's Monday

9ffb7cf

if this works I get to drink a beer even tho today it's Monday 2

572b588

toteki approved these changes Apr 4, 2022

View reviewed changes

Merge branch 'main' into facu/upgrade-gb

a0730db

adamewozniak approved these changes Apr 4, 2022

View reviewed changes

app/app.go Outdated Show resolved Hide resolved

app/app.go Outdated Show resolved Hide resolved

just fixing up some minor stuff

6956a86

adamewozniak added the A:Automerge label Apr 4, 2022

mergify bot merged commit 3b596e0 into main Apr 4, 2022

mergify bot deleted the facu/upgrade-gb branch April 4, 2022 23:14

mergify bot mentioned this pull request Apr 4, 2022

feat: update gravity bridge to v1.5.0 + upgrade handler for Calypso (v2.0.0) (backport #729) #736

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: update gravity bridge to v1.5.0 + upgrade handler for Calypso (v2.0.0) #729

feat: update gravity bridge to v1.5.0 + upgrade handler for Calypso (v2.0.0) #729

facundomedica commented Mar 31, 2022 •

edited

toteki commented Apr 2, 2022

adamewozniak left a comment

toteki left a comment

toteki left a comment

adamewozniak left a comment

feat: update gravity bridge to v1.5.0 + upgrade handler for Calypso (v2.0.0) #729

feat: update gravity bridge to v1.5.0 + upgrade handler for Calypso (v2.0.0) #729

Conversation

facundomedica commented Mar 31, 2022 • edited

Description

Author Checklist

Reviewers Checklist

toteki commented Apr 2, 2022

adamewozniak left a comment

Choose a reason for hiding this comment

toteki left a comment

Choose a reason for hiding this comment

toteki left a comment

Choose a reason for hiding this comment

adamewozniak left a comment

Choose a reason for hiding this comment

facundomedica commented Mar 31, 2022 •

edited