Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unexpected tsconfig.json from JavaScript creation #83

Merged
merged 2 commits into from
Sep 30, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/generators/ant-design-pro/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ class AntDesignProGenerator extends BasicGenerator {
});

log('[JS] Clean up...');
const removeTsFiles = globList(['**/*.d.ts'], envOptions);
const removeTsFiles = globList(['tsconfig.json', '**/*.d.ts'], envOptions);
removeTsFiles.forEach(filePath => {
const targetPath = path.resolve(projectPath, filePath);
fs.removeSync(targetPath);
Expand Down
24 changes: 24 additions & 0 deletions test/index.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -91,4 +91,28 @@ describe('test umi-create', () => {
assert.equal(response.stdout, expectStdout.join('\n'));
assert.equal(response.code, 0);
});

it('tsconfig.json should be removed if JavaScript is picked', async () => {
let temp = fs.mkdtempSync(path.join(os.tmpdir(), `umi-create`));
if (os.platform() === 'darwin') {
temp = path.join('/private', temp);
}
const Coffee = coffee.Coffee;
const fixtures = path.join(__dirname, 'fixtures');
const response = await new Coffee({
method: 'fork',
cmd: path.join(__dirname, '../cli.js'),
opt: { cwd: temp },
})
.beforeScript(path.join(fixtures, 'mock_cnpmjs.js'))
.waitForPrompt()
.write('\n')
.waitForPrompt()
.writeKey('DOWN', 'ENTER')
.end();

assert.equal(response.code, 0);
assert.ok(fs.existsSync(path.join(temp, 'jsconfig.json')));
assert.ok(!fs.existsSync(path.join(temp, 'tsconfig.json')));
});
});