Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: babel compile failed for demo #1817

Merged
merged 4 commits into from
Aug 3, 2023
Merged

fix: babel compile failed for demo #1817

merged 4 commits into from
Aug 3, 2023

Conversation

PeachScript
Copy link
Member

@PeachScript PeachScript commented Aug 3, 2023

🤔 这个变动的性质是?/ What is the nature of this change?

  • 新特性提交 / New feature
  • bug 修复 / Fix bug
  • 样式优化 / Style optimization
  • 代码风格优化 / Code style optimization
  • 性能优化 / Performance optimization
  • 构建优化 / Build optimization
  • 网站、文档、Demo 改进 / Website, documentation, demo improvements
  • 重构代码或样式 / Refactor code or style
  • 测试相关 / Test related
  • 其他 / Other

🔗 相关 Issue / Related Issue

ant-design/ant-design-pro#10829

💡 需求背景和解决方案 / Background or solution

dumi v1 没有锁定 babel 版本但 Umi 3 预打包变相锁定了 babel 及相关插件的版本,而 @babel/core@^7.22.6 和 Umi 3 预打包的插件不兼容,会导致 demo 编译报错

解决方案:考虑到 Umi 3 升级 babel 的改动影响不好评估,所以锁定 dumi v1 版本的 babel 依赖与 Umi 3 预打包的 babel 保持一致,以修复该问题

📝 更新日志 / Changelog

Language Changelog
🇺🇸 English Fix babel compile failed for demo
🇨🇳 Chinese 修复 babel 编译 demo 失败的问题

@vercel
Copy link

vercel bot commented Aug 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dumi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 3, 2023 7:15am

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

❗ No coverage uploaded for pull request base (1.x@e1f5786). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@          Coverage Diff           @@
##             1.x    #1817   +/-   ##
======================================
  Coverage       ?   94.69%           
======================================
  Files          ?      119           
  Lines          ?     2960           
  Branches       ?      985           
======================================
  Hits           ?     2803           
  Misses         ?      153           
  Partials       ?        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant