Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: demo localized title and description not working bug #2037

Merged
merged 3 commits into from
Mar 13, 2024

Conversation

liuyib
Copy link
Contributor

@liuyib liuyib commented Mar 6, 2024

🤔 这个变动的性质是?/ What is the nature of this change?

  • 新特性提交 / New feature
  • bug 修复 / Fix bug
  • 样式优化 / Style optimization
  • 代码风格优化 / Code style optimization
  • 性能优化 / Performance optimization
  • 构建优化 / Build optimization
  • 网站、文档、Demo 改进 / Website, documentation, demo improvements
  • 重构代码或样式 / Refactor code or style
  • 测试相关 / Test related
  • 其他 / Other

🔗 相关 Issue / Related Issue

v2 版本中,demo 的多语言切换没有实现,v1 中正常

💡 需求背景和解决方案 / Background or solution

📝 更新日志 / Changelog

Language Changelog
🇺🇸 English fix: locale not work in demo
🇨🇳 Chinese fix: demo 中多语言设置无效

Copy link

vercel bot commented Mar 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dumi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 7, 2024 2:51am

src/assetParsers/block.ts Show resolved Hide resolved
src/assetParsers/block.ts Outdated Show resolved Hide resolved
src/assetParsers/block.ts Show resolved Hide resolved
@PeachScript PeachScript changed the title fix: locale not work in demo fix: demo localized title and description not working bug Mar 6, 2024
@liuyib
Copy link
Contributor Author

liuyib commented Mar 7, 2024

@PeachScript 大佬,可以再看下~

Copy link
Member

@PeachScript PeachScript left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@PeachScript PeachScript merged commit b1bd0c7 into umijs:master Mar 13, 2024
9 checks passed
@liuyib liuyib deleted the fix_locale_in_demo branch March 13, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants