-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add dumi-theme-mobile #287
Conversation
xiaohuoni
commented
Aug 17, 2020
•
edited
Loading
edited
Codecov Report
@@ Coverage Diff @@
## master #287 +/- ##
==========================================
+ Coverage 88.15% 89.44% +1.29%
==========================================
Files 81 87 +6
Lines 1570 1706 +136
Branches 548 565 +17
==========================================
+ Hits 1384 1526 +142
+ Misses 182 176 -6
Partials 4 4
Continue to review full report at Codecov.
|
@PeachScript 到你上场了。页面要重新设计一下。 |
@xiaohuoni 神速👍 用例也加一下呗,辛辛苦苦到的 87%… |
可以加个 https://github.com/afc163/surge-preview 用来预览效果。 |
|
🎊 PR Preview 445d173 has been successfully built and deployed to https://umijs-dumi-pr-287.surge.sh 🕐 Build time: 235.447s 🤖 By surge-preview |
@PeachScript 现在的构建流程中,好像没办法使用 mobile 主题。因为它的生效机制是在 package.json 中包含它。 |
嗯嗯,可以加个配置项手动指定主题路径,和 umi 的 |
This comment has been minimized.
This comment has been minimized.
@xiaohuoni |
This comment has been minimized.
This comment has been minimized.
@PeachScript 代码干净了很多,发现三个问题记录如下,请跟进。 问题1: |
@afc163 能支持环境变量之类的预览嘛? |
@xiaohuoni 这个有思路吗,没想到优雅的方式实现 |
@xiaohuoni 已支持多个预览任务:afc163/surge-preview#16 |
🎊 PR Preview 34cc1b6 has been successfully built and deployed to https://umijs-dumi-preview-pr-287.surge.sh 🕐 Build time: 229.302s 🤖 By surge-preview |
现在还差什么 |
应该还有 3 个待解决问题:
|
@PeachScript 剩下单测覆盖率这个问题了。 |
+1,给 @xiaohuoni 纪念下 |
反馈一个bug, .umirc中有 base的时候手机框中的iframe路由错误,组件出不来 |
在 #335 (comment) 回复了 |
现在,rem的问题解决了么,如何配置对应设计稿标准呢,750的设计稿 |
px可以自动转成rem吗 |
px 转 rem 是工程化的问题,不是组件设计的吧?如果你要在组件库中自动转rem,自己加一个 PostCSS 插件 postcss-plugin-px2rem |