Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add hero image #396

Merged
merged 3 commits into from Nov 27, 2020
Merged

feat: add hero image #396

merged 3 commits into from Nov 27, 2020

Conversation

xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented Nov 27, 2020

close #393

新增首页标题配图

Preview

image

@github-actions
Copy link

github-actions bot commented Nov 27, 2020

😭 Deploy PR Preview edc197b failed. Build logs

🤖 By surge-preview

@github-actions
Copy link

github-actions bot commented Nov 27, 2020

🎊 PR Preview edc197b has been successfully built and deployed to https://umijs-dumi-preview-pr-396.surge.sh

🕐 Build time: 229.841s

🤖 By surge-preview

Co-authored-by: Peach <scdzwyxst@gmail.com>
@PeachScript
Copy link
Member

要不 dumi 文档还是拿掉 hero.image,看着这么大碗饭,好容易饿…

@codecov
Copy link

codecov bot commented Nov 27, 2020

Codecov Report

Merging #396 (edc197b) into master (129a2da) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #396   +/-   ##
=======================================
  Coverage   93.01%   93.01%           
=======================================
  Files         105      105           
  Lines        2076     2077    +1     
  Branches      695      676   -19     
=======================================
+ Hits         1931     1932    +1     
  Misses        141      141           
  Partials        4        4           
Impacted Files Coverage Δ
packages/theme-default/src/layout.tsx 85.71% <100.00%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 129a2da...edc197b. Read the comment docs.

@xrkffgg
Copy link
Member Author

xrkffgg commented Nov 27, 2020

要不 dumi 文档还是拿掉 hero.image,看着这么大碗饭,好容易饿…

好的 👌

docs/index.md Outdated Show resolved Hide resolved
@PeachScript PeachScript merged commit 204f044 into umijs:master Nov 27, 2020
@xrkffgg xrkffgg deleted the feat-hero-image branch November 27, 2020 09:05
@mizi-lin
Copy link

这哪个版本支持了?

@PeachScript
Copy link
Member

1.1.0-rc 版

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: layout hero support img
3 participants