Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 当使用APP_ROOT时,在github编辑此页的路径问题 #857

Merged
merged 1 commit into from
Aug 31, 2021

Conversation

MrSeaWave
Copy link
Contributor

🤔 这个变动的性质是?/ What is the nature of this change?

  • 新特性提交 / New feature
  • bug 修复 / Fix bug
  • 样式优化 / Style optimization
  • 代码风格优化 / Code style optimization
  • 性能优化 / Performance optimization
  • 构建优化 / Build optimization
  • 网站、文档、Demo 改进 / Website, documentation, demo improvements
  • 重构代码或样式 / Refactor code or style
  • 测试相关 / Test related
  • 其他 / Other

🔗 相关 Issue / Related Issue

856

💡 需求背景和解决方案 / Background or solution

meta.filePath取自path.relative(process.cwd(), this.data('fileAbsPath') 而不是 path.relative(ctx.umi?.cwd || process.cwd(), this.data('fileAbsPath'))

📝 更新日志 / Changelog

Language Changelog
🇺🇸 English when use APP_ROOT,fix Edit this doc on GitHub link
🇨🇳 Chinese 修复当设定APP_ROOT 时,Edit this doc on GitHub指向问题

@github-actions
Copy link

github-actions bot commented Aug 31, 2021

🎊 PR Preview has been successfully built and deployed to https://dumi-preview-pr-857.surge.sh

@github-actions
Copy link

github-actions bot commented Aug 31, 2021

🎊 PR Mobile Preview has been successfully built and deployed to https://dumi-mobile-preview-pr-857.surge.sh

Copy link
Member

@PeachScript PeachScript left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@codecov
Copy link

codecov bot commented Aug 31, 2021

Codecov Report

Merging #857 (81cf69d) into master (57d4133) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #857      +/-   ##
==========================================
- Coverage   94.61%   94.61%   -0.01%     
==========================================
  Files         112      112              
  Lines        2581     2580       -1     
  Branches      826      825       -1     
==========================================
- Hits         2442     2441       -1     
  Misses        135      135              
  Partials        4        4              
Impacted Files Coverage Δ
...ackages/preset-dumi/src/transformer/remark/meta.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57d4133...81cf69d. Read the comment docs.

@PeachScript
Copy link
Member

project coverage 是代码行数变少导致,PR 合并

@PeachScript PeachScript merged commit c034b73 into umijs:master Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants