Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复extraRollupPlugins重复引入相同插件,传入的配置参数无法覆盖原有配置的问题【https://github.c… #445

Merged
merged 5 commits into from
Jan 21, 2022

Conversation

Zoro916
Copy link
Contributor

@Zoro916 Zoro916 commented Jan 14, 2022

…om//issues/164

@Zoro916
Copy link
Contributor Author

Zoro916 commented Jan 20, 2022

@PeachScript 请问这个pr考虑合并吗?目前工作中用到这部分功能,迫切需要用到了。

@codecov
Copy link

codecov bot commented Jan 21, 2022

Codecov Report

Merging #445 (f06da51) into master (d55901d) will increase coverage by 0.24%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #445      +/-   ##
==========================================
+ Coverage   73.96%   74.20%   +0.24%     
==========================================
  Files          17       17              
  Lines         530      535       +5     
  Branches      193      194       +1     
==========================================
+ Hits          392      397       +5     
  Misses        137      137              
  Partials        1        1              
Impacted Files Coverage Δ
packages/father-build/src/getRollupConfig.ts 97.89% <100.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce8b1c9...f06da51. Read the comment docs.

@PeachScript PeachScript merged commit c1fd665 into umijs:master Jan 21, 2022
@PeachScript
Copy link
Member

@PeachScript 请问这个pr考虑合并吗?目前工作中用到这部分功能,迫切需要用到了。

  • father-build@1.21.0 ,可以试试

@Zoro916
Copy link
Contributor Author

Zoro916 commented Jan 21, 2022

好的!感谢!

@yang200258
Copy link

@PeachScript 请问这个pr考虑合并吗?目前工作中用到这部分功能,迫切需要用到了。

  • father-build@1.21.0 ,可以试试

大佬好,切换到1.21.0后,还存在同样的问题,有两个commonjs plugin,umd打包异常
Uploading image.png…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants