Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: skip d.ts files when doctor parsing #700

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

PeachScript
Copy link
Member

doctor 在收集源代码文件的时候过滤掉 .d.ts 文件,两个原因:

  1. doctor 预期是只查 JavaScript 和 TypeScript 源代码,类型文件不在目前的设计内
  2. esbuid 对 .d.ts 文件内容的报错不如 tsc 人性化,不如交给 IDE 或交给 build 来提示

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (2150873) 93.81% compared to head (8f51cc6) 93.81%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #700   +/-   ##
=======================================
  Coverage   93.81%   93.81%           
=======================================
  Files          54       54           
  Lines        1537     1537           
  Branches      365      365           
=======================================
  Hits         1442     1442           
- Misses         90       95    +5     
+ Partials        5        0    -5     
Files Changed Coverage Δ
src/doctor/index.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PeachScript PeachScript merged commit 9ab6ff3 into master Aug 31, 2023
9 checks passed
@delete-merged-branch delete-merged-branch bot deleted the hotfix/doctor-parse-d-ts branch August 31, 2023 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant