Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use hash instead mtime for cache key #718

Merged
merged 2 commits into from
Sep 19, 2023

Conversation

PeachScript
Copy link
Member

@PeachScript PeachScript commented Sep 19, 2023

使用 content hash 作为缓存键,替代原有的 mtime,这样 CI 环境也可以将 cache 复用

顺便修正了 bundle 模块源码中的变量名,由于不影响用户使用就不新开 PR 处理了,Close #709

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (b8a7a79) 94.39% compared to head (0411b4d) 94.39%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #718   +/-   ##
=======================================
  Coverage   94.39%   94.39%           
=======================================
  Files          55       55           
  Lines        1551     1553    +2     
  Branches      369      367    -2     
=======================================
+ Hits         1464     1466    +2     
+ Misses         87       82    -5     
- Partials        0        5    +5     
Files Changed Coverage Δ
src/builder/bundle/index.ts 100.00% <100.00%> (ø)
src/builder/bundless/loaders/index.ts 80.95% <100.00%> (+0.46%) ⬆️
src/doctor/parser.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PeachScript PeachScript merged commit d318d4f into master Sep 19, 2023
9 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feature/cache-by-contenthash branch September 19, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

为什么在bundle文件export default bundless,但是在使用的时候是 import bundle
1 participant