fix: gtag script error #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I run into this bug just now |
|
Hey @chenshuai2144 @xiaohuoni, this fix is very important as Google Analytics Universal will stop in 2 months and GA4 isn't working yet. @ZacksTsang is the author from previous PR that added GA4. This PR is a simple variable name correction. Easy to review. |
xiaohuoni
approved these changes
May 16, 2023
sorrycc
requested changes
May 16, 2023
|
@sorrycc done |
sorrycc
approved these changes
May 16, 2023
|
Version was not changed and did not publish to npm ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.