Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: request runtime config not work in sometimes #86

Merged
merged 3 commits into from
Mar 12, 2020
Merged

Conversation

yutingzhao1991
Copy link

类似之前的 umijs/plugin-request#12

不能直接在模块初始化的时候去初始化运行时配置,当用户的 app.ts 中依赖了该文件的情况下就该模块的初始化时间就会被提前,无法获取到运行时配置。

@codecov
Copy link

codecov bot commented Mar 12, 2020

Codecov Report

Merging #86 into master will increase coverage by 0.26%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
+ Coverage   53.45%   53.72%   +0.26%     
==========================================
  Files          60       60              
  Lines        1214     1221       +7     
  Branches      337      338       +1     
==========================================
+ Hits          649      656       +7     
  Misses        565      565              
Impacted Files Coverage Δ
packages/plugin-request/src/request.ts 93.93% <93.33%> (+0.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 145108f...9457223. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants