fixbug1352，适配vue3 并修改代码缩进 #1379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gongshun
previously approved these changes
Apr 9, 2021
|
是碰到了啥问题需要锁版本才能解？ |
|
这个是最近出现的吗？我记得以前 vue3 demo 是能正常启动的吧？ @gongshun |
|
应该是最近 而且我用的web pack5 和node14
发自我的iPhone
…------------------ 原始邮件 ------------------
发件人: Kuitos ***@***.***>
发送时间: 2021年4月9日 17:04
收件人: umijs/qiankun ***@***.***>
抄送: peterWang ***@***.***>, Author ***@***.***>
主题: 回复：[umijs/qiankun] fixbug1352，适配vue3 并修改代码缩进 (#1379)
这个是最近出现的吗？我记得以前 vue3 demo 是能正常启动的吧？ @gongshun
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
是的 应该是新的依赖不兼容 所以最好锁定版本
发自我的iPhone
…------------------ 原始邮件 ------------------
发件人: gongshun ***@***.***>
发送时间: 2021年4月9日 17:41
收件人: umijs/qiankun ***@***.***>
抄送: peterWang ***@***.***>, Author ***@***.***>
主题: 回复：[umijs/qiankun] fixbug1352，适配vue3 并修改代码缩进 (#1379)
这个是最近出现的吗？我记得以前 vue3 demo 是能正常启动的吧？ @gongshun
是最近出现的，以前可以正常启动，依赖更新了跑不起来，#1352
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
咦？为啥关了？是依赖没问题了？ |
|
我用 vue-cli 建了个 vue3 项目试了下，应该只需要加这两个版本依赖就可以了： + "less": "^3.0.4",
+ "less-loader": "^5.0.0" |
试了下，只加这两个依赖，可以跑起来 |
|
是的 昨天我也测了 可以的 这个版本真害人 😄
发自我的iPhone
…------------------ 原始邮件 ------------------
发件人: gongshun ***@***.***>
发送时间: 2021年4月12日 23:30
收件人: umijs/qiankun ***@***.***>
抄送: peterWang ***@***.***>, Mention ***@***.***>
主题: 回复：[umijs/qiankun] fixbug1352，适配vue3 并修改代码缩进 (#1379)
我用 vue-cli 建了个 vue3 项目试了下，应该只需要加这两个版本依赖就可以了：
"less": "^3.0.4",
"less-loader": "^5.0.0"
试了下，只加这两个依赖，可以跑起来
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
那就用这两个依赖吧，跟 vue-cli 创建出来的保持一致。 @WangHao1221 pr 修改一下？ |
kuitos
requested changes
Apr 13, 2021
|
我直接 suggestion commit 了 |
|
好的好的 看到了 这样的确方便一些，条条大路通罗马😄
发自我的iPhone
…------------------ 原始邮件 ------------------
发件人: Kuitos ***@***.***>
发送时间: 2021年4月13日 14:32
收件人: umijs/qiankun ***@***.***>
抄送: peterWang ***@***.***>, Mention ***@***.***>
主题: 回复：[umijs/qiankun] fixbug1352，适配vue3 并修改代码缩进 (#1379)
我直接 suggestion commit 了
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
kuitos
pushed a commit
that referenced
this pull request
May 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.只是修改锁定依赖即可
2.npm test测试通过
3.eslint校验通过
4.建议加上lock,这个版本适配问题比较花费时间
resolved #1352
resolved #1382