🐛 fix scripts in package.json #1469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
gongshun
commented
May 25, 2021
gongshun
commented
kuitos
requested changes
May 25, 2021
| @@ -17,7 +17,7 @@ | |||
| "scripts": { | |||
| "examples:install": "npm-run-all --serial build install:*", | |||
| "examples:start": "npm-run-all --parallel start:*", | |||
| "examples:start-multiple": "run-p start:main-multiple start:react15 start:vue", | |||
| "examples:start-multiple": "run-p start-main-multiple start:react15 start:vue", | |||
| "install:main": "cd examples/main && yarn", | |||
| "start:main": "cd examples/main && yarn start", | |||
| "start-main-multiple": "cd examples/main && yarn start:multiple", | |||
There was a problem hiding this comment.
应该把这里改成 start:main-multiple 更好一点，跟其他 script 保持一致
There was a problem hiding this comment.
如果把 start-main-multiple 改成 start:main-multiple，那么examples:start 命令也会运行 start:main-multiple 的，这是不必要的。最开始写的就是 start:main-multiple，后面被修改了，8c7efcc
kuitos
approved these changes
May 25, 2021
| @@ -17,7 +17,7 @@ | |||
| "scripts": { | |||
| "examples:install": "npm-run-all --serial build install:*", | |||
| "examples:start": "npm-run-all --parallel start:*", | |||
| "examples:start-multiple": "run-p start:main-multiple start:react15 start:vue", | |||
| "examples:start-multiple": "run-p start-main-multiple start:react15 start:vue", | |||
| "install:main": "cd examples/main && yarn", | |||
| "start:main": "cd examples/main && yarn start", | |||
| "start-main-multiple": "cd examples/main && yarn start:multiple", | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.