Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ add global error handler #256

Merged
merged 2 commits into from Feb 27, 2020
Merged

✨ add global error handler #256

merged 2 commits into from Feb 27, 2020

Conversation

kuitos
Copy link
Member

@kuitos kuitos commented Feb 23, 2020 •
edited

Checklist
  • npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

This change is Reviewable

@kuitos
Copy link
Member Author

kuitos commented Feb 23, 2020

文档还需要补一下

Deturium
Deturium reviewed Feb 24, 2020
View reviewed changes
Copy link
Contributor

@Deturium Deturium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

还得更新下 API 文档吧

src/errorHandler.ts Outdated Show resolved Hide resolved
src/errorHandler.ts Show resolved Hide resolved
@kuitos
Copy link
Member Author

kuitos commented Feb 24, 2020

文档已更新。
为简化处理 window.onerror 拦截的方式去掉了，因为这货的入参很奇葩，跟 addEventListener 捕获到的不一样，但实际两个都能被触发。

Deturium
Deturium approved these changes Feb 27, 2020
View reviewed changes
Copy link
Contributor

@Deturium Deturium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Deturium Deturium merged commit 7285c03 into master Feb 27, 2020
@Deturium Deturium deleted the feat/error-handler branch February 27, 2020 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howel52 howel52 howel52 approved these changes

@Deturium Deturium Deturium approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@kuitos @howel52 @Deturium